compact TUI to monitor layers download progress#10281
Conversation
Codecov ReportBase: 72.79% // Head: 73.89% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10281 +/- ##
==========================================
+ Coverage 72.79% 73.89% +1.10%
==========================================
Files 2 2
Lines 272 272
==========================================
+ Hits 198 201 +3
+ Misses 62 60 -2
+ Partials 12 11 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
It's so cute!! |
ndeloof
force-pushed
the
tui
branch
2 times, most recently
from
f376e43 to
ffe3aa8
Compare
|
this unfortunately breaks the progress alignment, need to double check |
| current int64 | ||
| ) | ||
| if jm.Status == "Pull complete" || jm.Status == "Already exists" { | ||
| if jm.Status == "Pushed" || jm.Status == "Already exists" { |
There was a problem hiding this comment.
can this strings not use some sort of enum or const ?
(I don't know golang)
There was a problem hiding this comment.
unfortunately golang doesn't have enums
ideally, const should be defined by the Docker Engine API
williamdes
left a comment
williamdes
left a comment
There was a problem hiding this comment.
I tested it with my projects that had the initial scolling bug of docker-compose
Using artifact from: https://github.com/docker/compose/actions/runs/4182986999
The new UI you propose is comprehensive and clean !
It's easy to understand
Very good work !
ndeloof
force-pushed
the
tui
branch
5 times, most recently
from
1851b42 to
89a36ba
Compare
ndeloof
requested review from
a team,
StefanScherer,
glours,
milas,
nicksieger and
ulyssessouza
and removed request for
a team
ndeloof
force-pushed
the
tui
branch
2 times, most recently
from
cc0bbe9 to
51d7307
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
|
let me know if the recent changes need that I retry |
StefanScherer
left a comment
StefanScherer
left a comment
There was a problem hiding this comment.
I tried it on Windows in PowerShell/CMD/Windows terminal and looks good there as well.
4 participants
What I did
As terminal height might not allow to display per-layers download progress status, render a compact TUI using 8-dots braille chars as progress status
see demo on https://asciinema.org/a/4jZWUZfhcXouJPd1p6h0yMxtC