Skip to content

apply uid/gid when creating secret from environment#10084

Merged
glours merged 1 commit into
docker:v2from
ndeloof:secret_uid
Dec 15, 2022
Merged

apply uid/gid when creating secret from environment#10084
glours merged 1 commit into
docker:v2from
ndeloof:secret_uid

Conversation

@ndeloof

@ndeloof ndeloof commented Dec 15, 2022

Copy link
Copy Markdown
Contributor

What I did

Related issue
relates to #9648 but only applies to secret set from environment variable

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@codecov

codecov Bot commented Dec 15, 2022

Copy link
Copy Markdown

Codecov Report

Base: 75.79% // Head: 77.38% // Increases project coverage by +1.58% 🎉

Coverage data is based on head (5c1484e) compared to base (0fedddb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10084      +/-   ##
==========================================
+ Coverage   75.79%   77.38%   +1.58%     
==========================================
  Files           2        2              
  Lines         252      252              
==========================================
+ Hits          191      195       +4     
+ Misses         53       50       -3     
+ Partials        8        7       -1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 75.74% <0.00%> (+1.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours glours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours
glours enabled auto-merge December 15, 2022 14:54
@glours
glours merged commit 0eaa249 into docker:v2 Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants