Skip to content

introduce --timestamp option on compose up#10076

Merged
glours merged 1 commit into
docker:v2from
ndeloof:timestamp
Dec 15, 2022
Merged

introduce --timestamp option on compose up#10076
glours merged 1 commit into
docker:v2from
ndeloof:timestamp

Conversation

@ndeloof

@ndeloof ndeloof commented Dec 13, 2022

Copy link
Copy Markdown
Contributor

What I did
Add support for docker compose up --timestamp to align with same option on logs command.

Related issue
close #5730

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@ndeloof
ndeloof force-pushed the timestamp branch 2 times, most recently from 798b11e to 33318e2 Compare December 13, 2022 18:16
@codecov

codecov Bot commented Dec 13, 2022

Copy link
Copy Markdown

Codecov Report

Base: 76.98% // Head: 75.79% // Decreases project coverage by -1.19% ⚠️

Coverage data is based on head (84ea395) compared to base (1cb5536).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10076      +/-   ##
==========================================
- Coverage   76.98%   75.79%   -1.20%     
==========================================
  Files           2        2              
  Lines         252      252              
==========================================
- Hits          194      191       -3     
- Misses         51       53       +2     
- Partials        7        8       +1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 74.04% <0.00%> (-1.28%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@milas milas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is good - just the flag name 🙃

Comment thread cmd/compose/up.go Outdated
Comment thread cmd/formatter/logs.go Outdated
@ndeloof
ndeloof force-pushed the timestamp branch 3 times, most recently from df39e57 to d12a32b Compare December 14, 2022 08:52
@ndeloof
ndeloof requested a review from milas December 14, 2022 21:56

@glours glours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours
glours merged commit 1b1f783 into docker:v2 Dec 15, 2022
@daevidvincent

Copy link
Copy Markdown

This is exciting! I've waited literally YEARS for this. What version of docker compose will this show up in?
I'm on Ubuntu and running v2.12.2 currently (from the https://docs.docker.com/compose/install/linux/ page method)

@ndeloof
ndeloof deleted the timestamp branch December 16, 2022 07:47
@ndeloof

ndeloof commented Dec 16, 2022

Copy link
Copy Markdown
Contributor Author

@o-rashad

Copy link
Copy Markdown

@ndeloof, Thank you.

@dimikot

dimikot commented Oct 15, 2024

Copy link
Copy Markdown

But why there is no space after the timestamp? And why it is so long, fractional digits after seconds...

2024-10-15T02:48:12.980702000-07:00app.service: [worker:1770481238978239

Should ideally be:

2024-10-15T02:48:12: app.service: [worker:1770481238978239

@ndeloof

ndeloof commented Oct 15, 2024

Copy link
Copy Markdown
Contributor Author

timestamp format is set by docker engine, compose receives a pre-formatted string which is written on console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add --timestamps option for "up" command

6 participants