align compose ps output with docker ps#10065
Conversation
adbd655 to
1c59aa9
Compare
ndeloof
changed the title
compose ps output with docker pscompose ps output with docker ps
45136ba to
2f89b88
Compare
Codecov ReportBase: 77.02% // Head: 76.98% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## v2 #10065 +/- ##
==========================================
- Coverage 77.02% 76.98% -0.04%
==========================================
Files 2 2
Lines 235 252 +17
==========================================
+ Hits 181 194 +13
- Misses 48 51 +3
- Partials 6 7 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2f89b88 to
8bfac9f
Compare
8bfac9f to
aa08375
Compare
aa08375 to
ad9cc19
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
Signed-off-by: Nicolas De Loof <[email protected]>
ad9cc19 to
902b7cd
Compare
| return formatter.Print(containers, opts.Format, os.Stdout, | ||
| writer(containers), | ||
| "NAME", "COMMAND", "SERVICE", "STATUS", "PORTS") | ||
| "NAME", "IMAGE", "COMMAND", "SERVICE", "CREATED", "STATUS", "PORTS") |
There was a problem hiding this comment.
Do you think it would be weird to show the value/path from dockerfile for services that Compose built (instead of the auto-generated image name)?
There was a problem hiding this comment.
Not sure. We would get this path from the current compose file, so this would only work when ran with a --file but not with --project-name, and even with this would assume the current compose file is in sync with listed containers.
| func Print(toJSON interface{}, format string, outWriter io.Writer, writerFn func(w io.Writer), headers ...string) error { | ||
| switch strings.ToLower(format) { | ||
| case PRETTY, "": | ||
| case TABLE, PRETTY, "": |
There was a problem hiding this comment.
Hurray for backwards compatibility 🎉
2 participants
What I did
Align
docker compose psoutput withdocker psfor an homogeneous user experience.Ideally, would share code with docker/cli, maybe something to be considered for a future PR :P
example:
Related issue
fixes #6867
(not mandatory) A picture of a cute animal, if possible in relation to what you did
