load project from files when explicitly set by user#10062
Merged
Conversation
Codecov ReportBase: 76.98% // Head: 76.98% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10062 +/- ##
=======================================
Coverage 76.98% 76.98%
=======================================
Files 2 2
Lines 252 252
=======================================
Hits 194 194
Misses 51 51
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ndeloof
force-pushed
the
9554
branch
4 times, most recently
from
December 15, 2022 11:15
4c4e54a to
7267957
Compare
milas
approved these changes
Dec 15, 2022
milas
left a comment
milas
left a comment
Contributor
There was a problem hiding this comment.
Definitely more predictable behavior-wise this way!
Signed-off-by: Nicolas De Loof <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a user run
docker compose --file foo.yaml --project-name bar ..., parse the provided compose file as source of truth for the compose model the command will execute upon. Project should only be built from actual resources when there's no explicit compose file being set and we only rely on a project name.Related issue
fixes #9554
(not mandatory) A picture of a cute animal, if possible in relation to what you did
