remove go.* from e2e tests directory#10059
Merged
Merged
Conversation
Signed-off-by: Guillaume Lours <[email protected]>
glours
force-pushed
the
remve-e2e-go.mod
branch
from
December 8, 2022 18:06
19f5dad to
cc247fd
Compare
glours
requested review from
a team,
StefanScherer,
laurazard,
milas,
ndeloof,
nicksieger and
ulyssessouza
and removed request for
a team
December 8, 2022 18:07
ndeloof
approved these changes
Dec 8, 2022
Codecov ReportBase: 75.74% // Head: 75.74% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10059 +/- ##
=======================================
Coverage 75.74% 75.74%
=======================================
Files 2 2
Lines 235 235
=======================================
Hits 178 178
Misses 50 50
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
laurazard
approved these changes
Dec 8, 2022
laurazard
left a comment
laurazard
left a comment
Member
There was a problem hiding this comment.
My christmas wish is test/dev dependencies for go 🎅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guillaume Lours [email protected]
What I did
Remove e2e test
go.modandgo.sum(not mandatory) A picture of a cute animal, if possible in relation to what you did
