Fix corner case when there's no container to attach to#10058
Conversation
Codecov ReportBase: 77.02% // Head: 77.02% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10058 +/- ##
=======================================
Coverage 77.02% 77.02%
=======================================
Files 2 2
Lines 235 235
=======================================
Hits 181 181
Misses 48 48
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
Looks good - does this actually address the linked issue, however?
AFAICT that issue isn't about "no container to attach to" cases but <svc>=0 being a way to exclude a service from launching as part of up without having to list out every other service
|
#8752 indeeds report another issue, but the latest codebase doesn't behaves as reported (scale=0 is well supported now), still the reported scenario demonstrates as a deadlock when |
Signed-off-by: Nicolas De Loof <[email protected]>
2 participants
What I did
Fixed a corner case:
if one run
docker compose up --scale helloworld=0with a single-service compose file, no container is actually created (as expected) andwatchwill never detect application terminationRelated issue
close #8752
(not mandatory) A picture of a cute animal, if possible in relation to what you did
