Don't stop pull for images that can be built#10054
Merged
Merged
Conversation
ndeloof
requested review from
glours,
laurazard,
milas,
nicksieger and
ulyssessouza
December 8, 2022 08:16
ndeloof
force-pushed
the
8724
branch
3 times, most recently
from
December 8, 2022 09:19
a5f25f6 to
f2810ef
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
Codecov ReportBase: 75.74% // Head: 75.74% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## v2 #10054 +/- ##
=======================================
Coverage 75.74% 75.74%
=======================================
Files 2 2
Lines 235 235
=======================================
Hits 178 178
Misses 50 50
Partials 7 7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
glours
approved these changes
Dec 8, 2022
|
hi @ndeloof - any chance that this broke the "--ignore-pull-failures" flag? I've always used it to pull images and ignore the one I build my self... but since the last update, it fails with I'm on Docker Compose version v2.14.1 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Don't immediately stop pulling on failure for image that can be built: Wait for other pullable images to complete.
Only stop with immediate error if some image can't be pulled and has no build config.
Note: this still eventually fails with a !=0 exit code. Maybe we should introduce a new flag to ignore pull failures on buildable services:
docker compose pull --ignore-buildable, wdyt ?Related issue
close #8724
(not mandatory) A picture of a cute animal, if possible in relation to what you did
