Skip to content

Cleanup tips from output#10047

Merged
glours merged 1 commit into
docker:v2from
thaJeztah:cleanup_output
Dec 6, 2022
Merged

Cleanup tips from output#10047
glours merged 1 commit into
docker:v2from
thaJeztah:cleanup_output

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

The scan tip has been shown for two years, and most users will know about it by now. Presenting the message also involved checking if the plugin was installed, and wether or not the message was shown before, which also caused some overhead, so cleaning up the output a bit.

The corresponding DOCKER_SCAN_SUGGEST environment-variable is also removed with this.

@glours glours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours
glours enabled auto-merge December 6, 2022 21:39
The scan tip has been shown for two years, and most users will know
about it by now. Presenting the message also involved checking if the
plugin was installed, and wether or not the message was shown before,
which also caused some overhead, so cleaning up the output a bit.

The corresponding DOCKER_SCAN_SUGGEST environment-variable is also
removed with this.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@glours
glours merged commit 6b4ad0d into docker:v2 Dec 6, 2022
@thaJeztah
thaJeztah deleted the cleanup_output branch December 6, 2022 22:42

@ndeloof ndeloof left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants