Skip to content

introduce --parallel to limit concurrent engine calls#10030

Merged
glours merged 1 commit into
docker:v2from
ndeloof:max_concurrency
Dec 6, 2022
Merged

introduce --parallel to limit concurrent engine calls#10030
glours merged 1 commit into
docker:v2from
ndeloof:max_concurrency

Conversation

@ndeloof

@ndeloof ndeloof commented Nov 30, 2022

Copy link
Copy Markdown
Contributor

What I did
Introduce --parallel=<int> for user to limit the concurrency during image pulls
could be later applied to other operations, typically build with adequate buildx|kit support for this

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@glours glours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tests are failing due to the wrong default value of the maxConcurrency attribute.
Docs should also be updated 😉

Comment thread pkg/compose/compose.go
@ndeloof
ndeloof force-pushed the max_concurrency branch 2 times, most recently from 51b5ee7 to 9bc188b Compare November 30, 2022 13:47
@laurazard

Copy link
Copy Markdown
Member

Oh nice! This is something that people have asked for for a while, albeit mostly regarding build operations.

@laurazard laurazard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! LGTM 🥳

@ndeloof

ndeloof commented Dec 6, 2022

Copy link
Copy Markdown
Contributor Author

@codecov-commenter

codecov-commenter commented Dec 6, 2022

Copy link
Copy Markdown

Codecov Report

Base: 77.02% // Head: 77.02% // No change to project coverage 👍

Coverage data is based on head (a0acc20) compared to base (6ed9a79).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2   #10030   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files           2        2           
  Lines         235      235           
=======================================
  Hits          181      181           
  Misses         48       48           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glours glours left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants