move image digests resolution to backend#10026
Conversation
milas
left a comment
milas
left a comment
There was a problem hiding this comment.
LGTM - small comment re: duplicated code
| @@ -141,8 +141,9 @@ func runConvert(ctx context.Context, backend api.Service, opts convertOptions, s | |||
| } | |||
There was a problem hiding this comment.
oh yes indeed, my bad
ndeloof
force-pushed
the
cli_registry_client
branch
from
c43cb10 to
1f2f68f
Compare
|
Not sure if useful, but there's also |
|
@thaJeztah thanks, this is exactly what I was looking for! 🥰 |
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
cli_registry_client
branch
from
e25e5be to
8e57c6e
Compare
|
Make sure to double check in the cli as well as at some point resolution was moved; check for "no-resolve-image" (I think) on the docker cli (I'm just away from my keyboard right now 😬😅) |
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
cli_registry_client
branch
from
8e57c6e to
1540ddf
Compare
| return yaml.Marshal(project) | ||
| default: | ||
| return nil, fmt.Errorf("unsupported format %q", options) | ||
| return nil, fmt.Errorf("unsupported format %q", options.Format) |
There was a problem hiding this comment.
linter suddenly noticed this bug, while it existed before ... weird
3 participants
What I did
introduced
ResolveImageDigestsin the API and moved image digest resolution to the backendlonger terms goal is to use
dockercli.RegistryClient()to replacecnab-to-ocidependency(not mandatory) A picture of a cute animal, if possible in relation with what you did
