Man page fixes#922
Merged
tiborvass merged 3 commits intodocker:masterfrom May 3, 2018
Merged
Conversation
Use the proper man typesetting when describing the options (i.e. use italics for variable parts, bold for literals). Expand the description. Give better examples. Refer to mknod(2). Signed-off-by: Kir Kolyshkin <[email protected]>
Do not mention the default value twice. Signed-off-by: Kir Kolyshkin <[email protected]>
The list of changes here is too long to be described. Maybe it's better to just rewrite the page from scratch, but at list this commit makes some things better than before. Signed-off-by: Kir Kolyshkin <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #922 +/- ##
=======================================
Coverage 53.55% 53.55%
=======================================
Files 262 262
Lines 16602 16602
=======================================
Hits 8891 8891
Misses 7121 7121
Partials 590 590 |
vdemeester
approved these changes
Mar 7, 2018
Collaborator
vdemeester
left a comment
vdemeester
left a comment
There was a problem hiding this comment.
LGTM 🍰
cc @thaJeztah
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frankly, I just wanted to fix a minor glitch in the docker-run(1) man page. One thing led to another, and I forced myself to stop at one point, resulting in this PR.