Container: let rm -f exit with success#821
Closed
akimd wants to merge 1 commit into
Closed
Conversation
`rm -f non-existing` exits with success, and so does `docker rmi -f non-existing`. But not `docker rm -f`. Signed-off-by: Akim Demaille <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
==========================================
- Coverage 51.67% 51.66% -0.02%
==========================================
Files 244 244
Lines 15823 15826 +3
==========================================
- Hits 8177 8176 -1
- Misses 7101 7105 +4
Partials 545 545 |
Contributor
|
This is the same change that was made to |
Contributor
Author
|
Thanks for the pointers! I'll have a look, but I can't tell when (yet). |
Member
|
Looks like this was addressed in #2678. The error is still printed, but the exit-code is docker rm nosuchcontainer
Error: No such container: nosuchcontainer
echo $?
1
docker rm -f nosuchcontainer
Error: No such container: nosuchcontainer
echo $?
0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rm -f non-existingexits with success, and so doesdocker rmi -f non-existing. But notdocker rm -f.Arguably we should actually check whether these errors are really doesNotExist (rm -f exits with failure for lack of permissions for instance), but at least we should be consistent.
FWIW, in the code, we have Rm in cli/command/container/rm.go and Remove in cli/command/image/remove.go. The latter has a test suite, not the former.
- A picture of a cute animal (not mandatory but encouraged)