-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Import opts package from moby/moby
#82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Docker-DCO-1.1-Signed-off-by: Victor Vieux <[email protected]> (github: vieux)
Add a --dns-search parameter and a DnsSearch configuration field for specifying dns search domains. Docker-DCO-1.1-Signed-off-by: Daniel Norberg <[email protected]> (github: danielnorberg)
Docker-DCO-1.1-Signed-off-by: Daniel Norberg <[email protected]> (github: danielnorberg)
match dock functionality, and not try to achieve shell-sourcing compatibility Docker-DCO-1.1-Signed-off-by: Vincent Batts <[email protected]> (github: vbatts)
trim the front of variables. Error if there are other spaces present. Leave the value alone. Docker-DCO-1.1-Signed-off-by: Vincent Batts <[email protected]> (github: vbatts)
In that case /etc/resolv.conf will be generated with no search option. Usage: --dns-search=. Docker-DCO-1.1-Signed-off-by: Fabio Falci <[email protected]> (github: fabiofalci)
Docker-DCO-1.1-Signed-off-by: Jan Pazdziora <[email protected]> (github: adelton)
Docker-DCO-1.1-Signed-off-by: Victor Vieux <[email protected]> (github: vieux)
Docker-DCO-1.1-Signed-off-by: Victor Vieux <[email protected]> (github: vieux)
functions to pkg/parsers/kernel, and parsing filters to pkg/parsers/filter. Adjust imports and package references. Docker-DCO-1.1-Signed-off-by: Erik Hollensbe <[email protected]> (github: erikh)
Docker-DCO-1.1-Signed-off-by: Tibor Vass <[email protected]> (github: tiborvass)
Signed-off-by: Solomon Hykes <[email protected]>
Signed-off-by: Solomon Hykes <[email protected]>
Signed-off-by: Solomon Hykes <[email protected]>
Signed-off-by: Solomon Hykes <[email protected]>
Adds support for a --registry-mirror=scheme://<host>[:port] daemon flag. The flag may be present multiple times. If provided, mirrors are prepended to the list of endpoints used for image pull. Note that only mirrors of the public index.docker.io registry are supported, and image/tag resolution is still performed via the official index. Docker-DCO-1.1-Signed-off-by: Tim Smith <[email protected]> (github: timbot)
Addresses #8057 Docker-DCO-1.1-Signed-off-by: Phil Estes <[email protected]>
This adds a --add-host host:ip flag which appends lines to /etc/hosts. This is needed in places where you want the container to get a different name resolution than it would through DNS. This was submitted before as docker#5525, closed, and now I am re-opening. It has come up 2 or 3 times in the last couple days. Signed-off-by: Tim Hockin <[email protected]>
used path package instead of path/filepath so that --volumes and --device parameters to always validate paths as unix paths instead of OS-dependent path convention Signed-off-by: Ahmet Alp Balkan <[email protected]>
Signed-off-by: Victor Vieux <[email protected]>
Passing RepositoryInfo to ResolveAuthConfig, pullRepository, and pushRepository Moving --registry-mirror configuration to registry config Created resolve_repository job Repo names with 'index.docker.io' or 'docker.io' are now synonymous with omitting an index name. Adding test for RepositoryInfo Adding tests for opts.StringSetOpts and registry.ValidateMirror Fixing search term use of repoInfo Adding integration tests for registry mirror configuration Normalizing LookupImage image name to match LocalName parsing rules Normalizing repository LocalName to avoid multiple references to an official image Removing errorOut use in tests Removing TODO comment gofmt changes golint comments cleanup. renaming RegistryOptions => registry.Options, and RegistryServiceConfig => registry.ServiceConfig Splitting out builtins.Registry and registry.NewService calls Stray whitespace cleanup Moving integration tests for Mirrors and InsecureRegistries into TestNewIndexInfo unit test Factoring out ValidateRepositoryName from NewRepositoryInfo Removing unused IndexServerURL Allowing json marshaling of ServiceConfig. Exposing ServiceConfig in /info Switching to CamelCase for json marshaling PR cleanup; removing 'Is' prefix from boolean members. Removing unneeded json tags. Removing non-cleanup related fix for 'localhost:[port]' in splitReposName Merge fixes for gh9735 Fixing integration test Reapplying #9754 Adding comment on config.IndexConfigs use from isSecureIndex Remove unused error return value from isSecureIndex Signed-off-by: Don Kjer <[email protected]> Adding back comment in isSecureIndex Signed-off-by: Don Kjer <[email protected]>
See #10141 for more info, but the main point of this is to make sure that if you do "docker run -e FOO ..." that FOO from the current env is passed into the container. This means that if there's a value, its set. But it also means that if FOO isn't set then it should be unset in the container too - even if it has to remove it from the env. So, unset HOSTNAME docker run -e HOSTNAME busybox env should _NOT_ show HOSTNAME in the list at all Closes #10141 Signed-off-by: Doug Davis <[email protected]>
Since the separator for extra host settings (for /etc/hosts in a container) is a ":", the code that handles extra hosts needed to only split on the first ":" to preserve IPv6 addresses which are passed via the command line settings as well as stored in the JSON container config. Docker-DCO-1.1-Signed-off-by: Phil Estes <[email protected]> (github: estesp)
Fixes: #10655 As noted in the issue, bad format was being returned even if the format was appropriate, but the IP was invalid. This adds a better error message for when the IP address fails validation. Docker-DCO-1.1-Signed-off-by: Phil Estes <[email protected]> (github: estesp)
Signed-off-by: Brian Goff <[email protected]>
Signed-off-by: Lei Jitang <[email protected]>
Signed-off-by: Tomáš Hrčka <[email protected]> Docker-DCO-1.1-Signed-off-by: Jessie Frazelle <[email protected]> (github: jfrazelle)
Signed-off-by: George MacRorie <[email protected]>
Signed-off-by: Antonio Murdaca <[email protected]>
Signed-off-by: jhowardmsft <[email protected]>
This adds support to specify custom container paths for secrets. Signed-off-by: Evan Hazlett <[email protected]>
Signed-off-by: Aaron Lehmann <[email protected]>
0de7beb to
8fd1bc8
Compare
opts package from dockeropts package from moby/moby
8fd1bc8 to
a8f826d
Compare
a8f826d to
6283d47
Compare
Also, rename a bunch of variable to not *shadow* the `opts` package name. Signed-off-by: Vincent Demeester <[email protected]>
6283d47 to
d7f6563
Compare
cpuguy83
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dnephin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix github.com/docker/docker/registry/config.go so it doesn't import docker/docker/opts. That will allow us to remove the package from vendor.
The cli flags should be added from this repo, not from some random package.
That will have to wait until after this PR.
LGTM
|
yep I'll handle |
|
💚 🎉 |
bump VERSION files to 17.06.0-ce
Static Dev builds should include date and sha Upstream-commit: 015af2c71e77fb99a9882301828bf8eafe4b95df Component: packaging
Imports the
optspackage frommoby/mobykeeping history. Part of moby/moby#33150 👼.Used the following to do it
The last commit (87948e7) renames the import and update few variable names to not shadow the package.