Skip to content

[Carry moby/moby#32777] Adjusted docker stats memory output#80

Merged
thaJeztah merged 2 commits into
docker:masterfrom
AkihiroSuda:adjust-docker-stats
May 17, 2017
Merged

[Carry moby/moby#32777] Adjusted docker stats memory output#80
thaJeztah merged 2 commits into
docker:masterfrom
AkihiroSuda:adjust-docker-stats

Conversation

@AkihiroSuda

Copy link
Copy Markdown
Collaborator

Carry moby/moby#32777 (comment)

cc @Sergeant007

Signed-off-by: Sergey Tryuber [email protected]
Signed-off-by: Akihiro Suda [email protected]

// Then
if !float64Equals(result, expected) {
t.Errorf("mem = %f, want %f", result, expected)
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sergeant007 and others added 2 commits May 16, 2017 02:00
Signed-off-by: Sergey Tryuber <[email protected]>
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
AkihiroSuda force-pushed the adjust-docker-stats branch from 060628d to 3c78bc7 Compare May 16, 2017 02:13
@AkihiroSuda

Copy link
Copy Markdown
Collaborator Author

done

@dnephin dnephin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@thaJeztah

Copy link
Copy Markdown
Member

looks like we have enough LGTM's, and CI is 💚

@thaJeztah
thaJeztah merged commit 85c2330 into docker:master May 17, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.06.0 milestone May 17, 2017
@taodd

taodd commented Nov 17, 2017

Copy link
Copy Markdown

why not add one more column to show the "cache" used by this container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants