-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated deprecation status for "repository:shortid" #753
Conversation
Codecov Report
@@ Coverage Diff @@
## master #753 +/- ##
=======================================
Coverage 53.45% 53.45%
=======================================
Files 218 218
Lines 14613 14613
=======================================
Hits 7811 7811
Misses 6321 6321
Partials 481 481 |
**Target For Removal In Release: v17.12** | ||
**Removed In Release: v17.12** | ||
|
||
The `repository:shortid` syntax for referencing images is very little used, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
references, and can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated, PTAL
The `repository:shortid` syntax for referencing images is very little used, collides with with tag references can be confused with digest references. The `repository:shortid` notation was deprecated in Docker 1.13, and scheduled for removal in Docker 17.12. This patch updates the deprecation status for this feature. Signed-off-by: Sebastiaan van Stijn <[email protected]>
c204da7
to
1a21ca1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦁
Depends on moby/moby#35790
The
repository:shortid
syntax for referencing images is very little used,collides with with tag references can be confused with digest references.
The
repository:shortid
notation was deprecated in Docker 1.13, and scheduledfor removal in Docker 17.12.
This patch updates the deprecation status for this feature.