[28.x backport] trust: print deprecation warning when using hub Notary server #6509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
reviewed
Sep 26, 2025
| return nil, err | ||
| } | ||
| if server == NotaryServer { | ||
| _, _ = fmt.Fprint(os.Stderr, dctDeprecation) |
Member
Author
There was a problem hiding this comment.
Ah, derp; master is no longer using pkg/errors probably because of that; let me fix
Member
Author
There was a problem hiding this comment.
Should be good now, PTAL 👍
Docker Hub's Notary service is being retired, and now produces failures in most cases. Add a warning when attempting to use it, pending full removal of trust; https://www.docker.com/blog/retiring-docker-content-trust/ With this PR: DOCKER_CONTENT_TRUST=1 docker pull -q hello-world WARNING: Docker is retiring DCT for Docker Official Images (DOI). For details, refer to https://docs.docker.com/go/dct-deprecation/ could not validate the path to a trusted root: unable to retrieve valid leaf certificates Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 43b03ef) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
28.x_backport_dct_retiring
branch
from
477a9e8 to
0351ece
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
robmry
approved these changes
Sep 26, 2025
austinvazquez
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker Hub's Notary service is being retired, and now produces failures in most cases. Add a warning when attempting to use it, pending full removal of trust;
https://www.docker.com/blog/retiring-docker-content-trust/
With this PR:
(cherry picked from commit 5d591f2)
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)