cli/command/system: remove BridgeNfIptables, BridgeNfIp6tables in tests#5696
Merged
akerouanton merged 1 commit intodocker:masterfrom Dec 16, 2024
Merged
Conversation
This is a follow-up to 55e404e, which removed some warnings related to these fields. These fields in the /info response were used to warn users if netfiltering was not enabled on the host when the daemon started. Starting with [moby@db25b0d], detecting whether netfiltering is enabled now [happens when needed][1], making the state that's detected at startup irrelevant. These fields will therefore be deprecated in future, but we can start removing their use in tests. [moby@db25b0d]: moby/moby@db25b0d [1]: https://github.com/moby/moby/blob/944e40350259f040950d871d402d848ff2a799bc/libnetwork/drivers/bridge/setup_bridgenetfiltering.go#L16-L77 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5696 +/- ##
==========================================
+ Coverage 59.51% 59.54% +0.02%
==========================================
Files 346 346
Lines 29379 29379
==========================================
+ Hits 17486 17494 +8
+ Misses 10923 10914 -9
- Partials 970 971 +1 |
akerouanton
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to 55e404e, which removed some warnings related to these fields.
These fields in the /info response were used to warn users if netfiltering was not enabled on the host when the daemon started. Starting with moby@db25b0d, detecting whether netfiltering is enabled now happens when needed, making the state that's detected at startup irrelevant.
These fields will therefore be deprecated in future, but we can start removing their use in tests.
- A picture of a cute animal (not mandatory but encouraged)