cli/command/system: remove netfilter warnings from tests#5691
Merged
thaJeztah merged 1 commit intodocker:masterfrom Dec 13, 2024
Merged
cli/command/system: remove netfilter warnings from tests#5691thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
These warnings will no longer be returned by the daemon, so remove them from the tests as well to make them more representative of reality. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/testing
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5691 +/- ##
=======================================
Coverage 59.51% 59.51%
=======================================
Files 346 346
Lines 29379 29379
=======================================
Hits 17486 17486
Misses 10923 10923
Partials 970 970 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These warnings will no longer be returned by the daemon, so remove them from the tests as well to make them more representative of reality.
- A picture of a cute animal (not mandatory but encouraged)