Skip to content

Use a local constant#551

Merged
thaJeztah merged 1 commit intodocker:masterfrom
dnephin:set-local-constant
Sep 26, 2017
Merged

Use a local constant#551
thaJeztah merged 1 commit intodocker:masterfrom
dnephin:set-local-constant

Conversation

@dnephin
Copy link
Contributor

@dnephin dnephin commented Sep 22, 2017

This constant is going to be removed from jsonlog package in moby/moby#34946

This constant is going to be removed from jsonlog package.

Signed-off-by: Daniel Nephin <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #551 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   49.08%   49.07%   -0.01%     
==========================================
  Files         200      200              
  Lines       16447    16447              
==========================================
- Hits         8073     8072       -1     
- Misses       7954     7955       +1     
  Partials      420      420

Copy link
Collaborator

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnephin
Copy link
Contributor Author

dnephin commented Sep 26, 2017

The moby/moby PR has merge so we should get this merged so it doesn't block any re-vendoring in the future.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thaJeztah thaJeztah merged commit 0856c20 into docker:master Sep 26, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.10.0 milestone Sep 26, 2017
@dnephin dnephin deleted the set-local-constant branch September 26, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants