telemetry: pass otel errors to the otel handler for shutdown and force flush#5444
Merged
laurazard merged 1 commit intodocker:masterfrom Sep 18, 2024
Merged
Conversation
…e flush Signed-off-by: Jonathan A. Sternberg <[email protected]>
laurazard
approved these changes
Sep 17, 2024
Member
|
Thanks! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5444 +/- ##
==========================================
- Coverage 59.75% 59.74% -0.01%
==========================================
Files 345 345
Lines 23428 23430 +2
==========================================
Hits 13999 13999
- Misses 8455 8457 +2
Partials 974 974 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Errors returned by otel shutdown and force flush methods are passed to
otel.Handleto be determined how or if they'll be printed.- How I did it
Checked for the error and invoked
otel.Handle.- How to verify it
- Description for the changelog
* Print OTEL errors in the CLI on shutdown- A picture of a cute animal (not mandatory but encouraged)