docs: add documentation for dockerd --feature flag#5436
Merged
thaJeztah merged 4 commits intodocker:masterfrom Sep 16, 2024
Merged
docs: add documentation for dockerd --feature flag#5436thaJeztah merged 4 commits intodocker:masterfrom
thaJeztah merged 4 commits intodocker:masterfrom
Conversation
commit f13c08246d93dd5aae200d5881a3a374e6cac876 introduced this flag, but did not yet update the manpage. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
The --feature flag allows the boolean value to be omitted. If only a name is provided, the default is "true". Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5436 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 345 345
Lines 23428 23428
=======================================
Hits 13999 13999
Misses 8455 8455
Partials 974 974 |
laurazard
reviewed
Sep 16, 2024
Comment on lines
+979
to
+982
| Using both the command-line option and the "features" field in the configuration | ||
| file produces an error. The feature option can be specified multiple times |
Member
There was a problem hiding this comment.
Suggested change
| Using both the command-line option and the "features" field in the configuration | |
| file produces an error. The feature option can be specified multiple times | |
| A feature should only be configured either through the `--feature` command line option or through the "features" field in the configuration file. | |
| Using both produces an error. The feature option can be specified multiple times |
I was thinking we could be a bit more explicit here.
laurazard
approved these changes
Sep 16, 2024
Member
laurazard
left a comment
laurazard
left a comment
There was a problem hiding this comment.
Left a suggestion, but overall LGTM
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
update_dockerd_docs
branch
from
eea16f0 to
a42ca11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to:
--featureto daemon flags moby/moby#48167First 3 commits were cherry-picked;