Docs: Fix --rm=false flag in container_run.md#5435
Merged
thaJeztah merged 1 commit intodocker:masterfrom Sep 16, 2024
Merged
Conversation
Signed-off-by: Julio Cesar Garcia <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5435 +/- ##
=======================================
Coverage 59.75% 59.75%
=======================================
Files 345 345
Lines 23428 23428
=======================================
Hits 13999 13999
Misses 8455 8455
Partials 974 974 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Corrected the usage of the
--rm=falseflag in thecontainer_run.mddocumentation example. See Docker Container Run - Clean up for reference.- How I did it
Removed the incorrect
--rm=falseflag from the example and updated it to use the--rmflag to comply with the example text:Automatically remove the container when it exits. Also for the--rm=trueflag it is not necessary to specify true, as that is the default behavior.- How to verify it
docker run --rm alpine echo "Hello World"in a Docker environment to confirm that the container is automatically removed after execution.docker run --rm=false alpine echo "Hello World"in a Docker environment to confirm that the container is not automatically removed after execution.--rmflag is used to remove a container when it exits. There is an error in the example of container run when it states that setting--rm=falsewill remove a container when it exits.- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)