Centralize init of Meter/TracerProviders#5067
Merged
laurazard merged 1 commit intodocker:masterfrom May 14, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5067 +/- ##
==========================================
+ Coverage 61.09% 61.35% +0.26%
==========================================
Files 298 298
Lines 20675 20685 +10
==========================================
+ Hits 12631 12691 +60
+ Misses 7147 7093 -54
- Partials 897 901 +4 |
krissetto
force-pushed
the
adjust-otel-utils
branch
2 times, most recently
from
9c8b62d to
0feb0dc
Compare
krissetto
force-pushed
the
adjust-otel-utils
branch
from
0feb0dc to
871f1b3
Compare
krissetto
force-pushed
the
adjust-otel-utils
branch
from
871f1b3 to
d0782f4
Compare
jsternberg
reviewed
May 13, 2024
vvoland
requested changes
May 14, 2024
krissetto
force-pushed
the
adjust-otel-utils
branch
from
d0782f4 to
926613b
Compare
laurazard
reviewed
May 14, 2024
Member
|
Chatted w/ @jsternberg, there's some other approaches that would be interesting to look at (take care of shutdown automatically in the CLI lifecycle), but he's okay with merging as-is for now to unblock releases and improving things later. |
vvoland
approved these changes
May 14, 2024
Collaborator
vvoland
left a comment
vvoland
left a comment
There was a problem hiding this comment.
LGTM; I think we should have a log in case the typecast fails (so like panic, but without actually panicking), so we can be aware if our assumptions are broken with future OTEL updates.
Not a blocker if you think it's fine though.
…e them. Initialize them during DockerCli struct init Signed-off-by: Christopher Petito <[email protected]>
krissetto
force-pushed
the
adjust-otel-utils
branch
from
926613b to
02537ea
Compare
thaJeztah
added
area/metrics/otel
status/4-merge
process/cherry-picked
and removed
process/cherry-pick/26.1
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Meter/TracerProviderfuncs onDockerClito return the providers rather than initialize them- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)