Add OTel instrumentation to CLI plugins#5051
Merged
laurazard merged 2 commits intodocker:masterfrom May 15, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5051 +/- ##
==========================================
- Coverage 61.35% 61.32% -0.04%
==========================================
Files 298 295 -3
Lines 20685 20687 +2
==========================================
- Hits 12691 12686 -5
- Misses 7093 7099 +6
- Partials 901 902 +1 |
laurazard
force-pushed
the
add-plugin-command-metrics
branch
from
822b9b8 to
d32860d
Compare
laurazard
force-pushed
the
add-plugin-command-metrics
branch
from
d32860d to
142cd99
Compare
laurazard
changed the title
laurazard
force-pushed
the
add-plugin-command-metrics
branch
3 times, most recently
from
d607756 to
8f0b236
Compare
vvoland
reviewed
May 7, 2024
vvoland
reviewed
May 7, 2024
vvoland
reviewed
May 7, 2024
krissetto
reviewed
May 7, 2024
laurazard
force-pushed
the
add-plugin-command-metrics
branch
from
8f0b236 to
ae0bc20
Compare
krissetto
reviewed
May 9, 2024
laurazard
force-pushed
the
add-plugin-command-metrics
branch
2 times, most recently
from
594f11d to
f7ffd69
Compare
laurazard
force-pushed
the
add-plugin-command-metrics
branch
2 times, most recently
from
3ddb0a8 to
9141f02
Compare
laurazard
force-pushed
the
add-plugin-command-metrics
branch
from
9141f02 to
aaffe49
Compare
laurazard
force-pushed
the
add-plugin-command-metrics
branch
from
aaffe49 to
e675a0a
Compare
Signed-off-by: Laura Brehm <[email protected]>
Signed-off-by: Laura Brehm <[email protected]>
laurazard
force-pushed
the
add-plugin-command-metrics
branch
from
e675a0a to
5f4f4f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Instrument CLI plugin commands to track
command.timemeter, same as the regular CLI commands.- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)