Skip to content

[26.0 backport] cli-bin/windows: Add .exe extension#5006

Merged
vvoland merged 1 commit intodocker:26.0from
vvoland:v26.0-5005
Apr 11, 2024
Merged

[26.0 backport] cli-bin/windows: Add .exe extension#5006
vvoland merged 1 commit intodocker:26.0from
vvoland:v26.0-5005

Conversation

@vvoland
Copy link
Collaborator

@vvoland vvoland commented Apr 11, 2024

Before this commit, the CLI binary in dockereng/cli-bin image was named docker regardless of platform.

Change the binary name to docker.exe in Windows images.

Before this commit, the CLI binary in `dockereng/cli-bin` image was
named `docker` regardless of platform.

Change the binary name to `docker.exe` in Windows images.

Signed-off-by: Paweł Gronowski <[email protected]>
(cherry picked from commit 718203d)
Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland added this to the 26.0.1 milestone Apr 11, 2024
@vvoland vvoland self-assigned this Apr 11, 2024
@vvoland vvoland requested a review from thaJeztah April 11, 2024 09:36
Copy link
Member

@Benehiko Benehiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@krissetto krissetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vvoland vvoland merged commit 3cf84fb into docker:26.0 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants