cli-bin/windows: Add .exe extension#5005
Merged
vvoland merged 1 commit intodocker:masterfrom Apr 11, 2024
Merged
Conversation
Before this commit, the CLI binary in `dockereng/cli-bin` image was named `docker` regardless of platform. Change the binary name to `docker.exe` in Windows images. Signed-off-by: Paweł Gronowski <[email protected]>
thaJeztah
approved these changes
Apr 10, 2024
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
this one doesn't impact the docker-ce-packging scripts? (in case there's code there consuming these)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5005 +/- ##
=======================================
Coverage 61.04% 61.04%
=======================================
Files 295 295
Lines 20648 20648
=======================================
Hits 12605 12605
Misses 7147 7147
Partials 896 896 |
Collaborator
Author
|
Yes, it doesn't affect anything else. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the CLI binary in
dockereng/cli-binimage was nameddockerregardless of platform.Change the binary name to
docker.exein Windows images.