docs: clarify that --data-path-addr doesn't restrict access#4997
Merged
thaJeztah merged 1 commit intodocker:masterfrom May 13, 2024
Merged
docs: clarify that --data-path-addr doesn't restrict access#4997thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Contributor
Author
|
cc @corhere |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4997 +/- ##
==========================================
- Coverage 61.04% 61.02% -0.03%
==========================================
Files 295 295
Lines 20648 20648
==========================================
- Hits 12605 12600 -5
- Misses 7147 7150 +3
- Partials 896 898 +2 |
Signed-off-by: David Karlsson <[email protected]>
dvdksn
force-pushed
the
doc-vxlan-listen-addr
branch
from
c77e7a0 to
faf096b
Compare
Member
|
Wondering if we should borrow some wording from cli/docs/reference/commandline/swarm_init.md Lines 95 to 109 in c23a404 |
corhere
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added a paragraph that clarifies the scope of the
--data-path-addrfordocker swarm init.Relates to moby/moby#47667
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)