otel: capture exit code as int64#4985
Merged
laurazard merged 1 commit intodocker:masterfrom Apr 5, 2024
Merged
Conversation
Signed-off-by: Laura Brehm <[email protected]>
jsternberg
approved these changes
Apr 4, 2024
Contributor
jsternberg
left a comment
jsternberg
left a comment
There was a problem hiding this comment.
Yea I think this is much better.
neersighted
approved these changes
Apr 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4985 +/- ##
=======================================
Coverage 61.03% 61.03%
=======================================
Files 295 295
Lines 20648 20648
=======================================
Hits 12603 12603
Misses 7148 7148
Partials 897 897 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Capture exit code as int64 (it used to be a string!)
- How I did it
By changing characters in source files!
- How to verify it
Run the relevant tests.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)