feat: standardize error for prompt#4939
Merged
thaJeztah merged 2 commits intodocker:masterfrom Apr 2, 2024
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4888
This PR standardizes the commands return value that use
PromptForConfirmationand verifies the exit code to be 0 on prompt termination.- What I did
Add e2e tests, update command prompt termination tests and adjust error type returned from
PromptForConfirmationfunction.- How I did it
- How to verify it
- Description for the changelog
Standardize the exit code to
0for cancelling a confirmation prompt with SIGINT.- A picture of a cute animal (not mandatory but encouraged)
