Add network create flags --scope, --config-only, --config-from#49
Add network create flags --scope, --config-only, --config-from#49mavenugo merged 2 commits intodocker:masterfrom aboch:nlo2
Conversation
|
Looks like this needs a rebase 😢 |
|
Let's keep this in design review until the API side is merged. |
| Labels: runconfigopts.ConvertKVStringsToMap(options.labels.GetAll()), | ||
| Scope: options.scope, | ||
| ConfigOnly: options.configOnly, | ||
| Labels: runconfigopts.ConvertKVStringsToMap(opts.labels.GetAll()), |
There was a problem hiding this comment.
shouldnt this be options.labels ?
There was a problem hiding this comment.
thanks, leftover form merge conflict
| } | ||
|
|
||
| if from := options.configFrom; from != "" { | ||
| nc.ConfigFrom = network.ConfigReference{ |
- To promote a network to swarm mode Signed-off-by: Alessandro Boch <[email protected]>
|
Thanks @thaJeztah @mavenugo Updated |
thaJeztah
added
status/2-code-review
impact/changelog
and removed
status/1-design-review
labels
mavenugo
left a comment
mavenugo
left a comment
There was a problem hiding this comment.
LGTM
This will need a rebase after moby/moby#32981 is merged and vendor updated.
|
@aboch @mavenugo please include moby/moby#33239 in the vendor here, it should be merged soon (CI almost done) |
|
@nishanttotla moby/moby#33239 is not changing any docker pkg exported function. |
|
@aboch it is changing the |
|
Oh I see, the whole client pkg is being used here. Got it. |
|
@nishanttotla we also have #62 which will be even later. |
moby/moby#32981 was just merged Time to rebase this PR? |
|
@eyz we are also waiting to pick up moby/moby#33239 as per @nishanttotla request. |
Signed-off-by: Alessandro Boch <[email protected]>
|
@mavenugo Updated vendoring to include moby/moby#33239 and CI is now green |
[18.09] Add Version and Commit to build
Do not log the CA config CA signing key in debug mode.
7 participants
This is for moby/moby/pull/32981 and depends on the moby PR to be merged first.