info: remove printSecurityOptionsWarnings, printServerWarnings#4809
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jan 24, 2024
Merged
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4809 +/- ##
==========================================
- Coverage 59.59% 59.58% -0.01%
==========================================
Files 287 287
Lines 24739 24722 -17
==========================================
- Hits 14742 14731 -11
+ Misses 9110 9106 -4
+ Partials 887 885 -2 |
Docker Engine 1.13 (API v1.25) added an option to set a custom default seccomp profile on the daemon (see [moby/moby@b237189]). A warning was added on the client-side if a non-default profile was set. Docker Engine 23.0 (API v1.42) added warnings about non-default seccomp profiles to the "info" response ([moby/moby@04f932a]), and the client was updated to skip generating client-side warnings for API v1.42 and up in [docker/cli@8964595]. These warnings are purely informational, and given that Docker Engine versions before 23.0 have reached EOL, and any current version of the Engine now returns the Warnings, it should be safe to remove the client-side fall back logic. This patch removes the client-side fall back code for warnings that was added in 8964595. [moby/moby@b237189]: moby/moby@b237189 [moby/moby@04f932a]: moby/moby@04f932a [docker/cli@8964595]: docker@8964595 Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_printSecurityOptionsWarnings
branch
from
3bb9911 to
d9294f0
Compare
sam-thibault
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to
info: remove printSecurityOptionsWarnings, printServerWarnings
Docker Engine 1.13 (API v1.25) added an option to set a custom default seccomp profile on the daemon (see moby/moby@b237189). A warning was added on the client-side if a non-default profile was set.
Docker Engine 23.0 (API v1.42) added warnings about non-default seccomp profiles to the "info" response (moby/moby@04f932a), and the client was updated to skip generating client-side warnings for API v1.42 and up in docker/cli@8964595.
These warnings are purely informational, and given that Docker Engine versions before 23.0 have reached EOL, and any current version of the Engine now returns the Warnings, it should be safe to remove the client-side fall back logic.
This patch removes the client-side fall back code for warnings that was added in 8964595.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)