cmd/docker: registerCompletionFuncForGlobalFlags: take store.Store as argument#4778
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jan 11, 2024
Merged
Conversation
… argument Update this function to accept a smaller interface, as it doesn't need all of "CLI". Also return errors encountered during its operation (although the caller currently has no error return on its own). Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4778 +/- ##
==========================================
- Coverage 59.62% 59.61% -0.02%
==========================================
Files 287 287
Lines 24777 24784 +7
==========================================
+ Hits 14774 14775 +1
- Misses 9117 9121 +4
- Partials 886 888 +2 |
neersighted
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update this function to accept a smaller interface, as it doesn't need all of "CLI". Also return errors encountered during its operation (although the caller currently has no error return on its own).
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)