Add docker ps status descriptions#4614
Merged
thaJeztah merged 1 commit intodocker:masterfrom Oct 20, 2023
sam-thibault:cli-issue-502
Merged
Add docker ps status descriptions#4614thaJeztah merged 1 commit intodocker:masterfrom sam-thibault:cli-issue-502
thaJeztah merged 1 commit intodocker:masterfrom
sam-thibault:cli-issue-502
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4614 +/- ##
=======================================
Coverage 59.72% 59.72%
=======================================
Files 288 288
Lines 24846 24846
=======================================
Hits 14839 14839
Misses 9120 9120
Partials 887 887 |
thaJeztah
reviewed
Oct 20, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
overall LGTM, but left a comment about formatting.
dvdksn
approved these changes
Oct 20, 2023
Contributor
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
LGTM, thanks @sam-thibault
Signed-off-by: Sam Thibault <[email protected]>
Contributor
|
|
Member
|
@dvdksn yes, we should backport this one to the v24 branch; didn't come round to that yet, but feel free to beat me to it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added a table to docker ps documentation to describe the meaning of each status.
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)