Skip to content

stacks: Add support for start interval#4593

Closed
cpuguy83 wants to merge 1 commit intodocker:masterfrom
cpuguy83:stack_start_interval
Closed

stacks: Add support for start interval#4593
cpuguy83 wants to merge 1 commit intodocker:masterfrom
cpuguy83:stack_start_interval

Conversation

@cpuguy83
Copy link
Collaborator

No description provided.

@cpuguy83 cpuguy83 added this to the 25.0.0 milestone Oct 11, 2023
@neersighted
Copy link
Member

cc @dperny

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #4593 (af75b49) into master (dcc1610) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4593      +/-   ##
==========================================
+ Coverage   59.71%   59.72%   +0.01%     
==========================================
  Files         288      288              
  Lines       24858    24862       +4     
==========================================
+ Hits        14843    14850       +7     
+ Misses       9128     9126       -2     
+ Partials      887      886       -1     

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@neersighted neersighted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, looks like we need to create a new schema version in cli/compose/schema.

@ndeloof
Copy link
Contributor

ndeloof commented Feb 3, 2024

docker/cli should not define some 3.10+ schema for compose file format, as this schema is maintained by https://github.com/compose-spec/compose-spec. This looks like some unofficial, unmaintained compose format fork, which deserve adoption of recent compose file features. Changes introduced by this schema could easily be supported by just adopting compose-go for compose file parsing, in replacement for the legacy parser.

@thaJeztah
Copy link
Member

The official v3 compose specification has always been maintained in this repository; compose happened to have a copy in its repository, and the compose-spec was forked from that.

@ndeloof
Copy link
Contributor

ndeloof commented Feb 4, 2024

compose file v3 indeed used to be maintained here, but this was before we (Docker) announced compose specification 4 years ago
compose-go indeed was forked from this code, then improved and partially rewritten. This should make it easier to adopt compose spec without much efforts, vs spending energy maintaining a distinct implementation

@cpuguy83 cpuguy83 deleted the stack_start_interval branch February 4, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants