Closed
Conversation
Signed-off-by: Evan Lezar <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4525 +/- ##
=======================================
Coverage 59.34% 59.34%
=======================================
Files 288 288
Lines 24787 24787
=======================================
Hits 14711 14711
Misses 9195 9195
Partials 881 881 |
thaJeztah
reviewed
Aug 28, 2023
Comment on lines
-1421
to
+1437
| | `etwlogs` | Event Tracing for Windows (ETW) events. Writes log messages as Event Tracing for Windows (ETW) events. Only Windows platforms. | | ||
| | `etwlogs` | Event Tracing for Windows (ETW) events. Writes log messages as Event Tracing for Windows (ETW) events. Only Windows platforms. | |
Member
There was a problem hiding this comment.
Opened a quick PR to get these unrelated changes already out of the way; #4536
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Added documentation on the use of the Container Device Interface to request devices through the
docker runcommand. The following PRs are relevant:experimentalfeature implementaton in Daemon: Add support for CDI devices under Linux moby/moby#45134- Description for the changelog
Added documentation on requesting CDI devices in
docker run- A picture of a cute animal (not mandatory but encouraged)
TODO:
docker compose--gpusflagRelated