cli/command: ResolveAuthConfig, GetDefaultAuthConfig: take ConfigFile as arg#4412
Merged
thaJeztah merged 1 commit intodocker:masterfrom Aug 8, 2023
Merged
cli/command: ResolveAuthConfig, GetDefaultAuthConfig: take ConfigFile as arg#4412thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
thaJeztah
force-pushed
the
auth_use_config
branch
from
ccab3ab to
831b588
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4412 +/- ##
==========================================
- Coverage 59.39% 59.39% -0.01%
==========================================
Files 288 288
Lines 24782 24779 -3
==========================================
- Hits 14720 14717 -3
Misses 9175 9175
Partials 887 887 |
… as arg Both these functions took the whole DockerCLI as argument, but only needed the ConfigFile. ResolveAuthConfig also had an unused context.Context as argument. This patch updates both functions to accept a ConfigFile, and removes the unused context.Context. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
auth_use_config
branch
from
831b588 to
211220c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both these functions took the whole DockerCLI as argument, but only needed the ConfigFile. ResolveAuthConfig also had an unused context.Context as argument.
This patch updates both functions to accept a ConfigFile, and removes the unused context.Context.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)