cli: SetupRootCommand: remove redundant flags return#4389
Merged
thaJeztah merged 1 commit intodocker:masterfrom Jun 28, 2023
Merged
cli: SetupRootCommand: remove redundant flags return#4389thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
thaJeztah
added
status/2-code-review
kind/refactor
thaJeztah
commented
Jun 28, 2023
| }, | ||
| } | ||
| opts, flags := cli.SetupPluginRootCommand(cmd) | ||
| opts, _ := cli.SetupPluginRootCommand(cmd) |
Member
Author
There was a problem hiding this comment.
FWIW; it could also be removed from SetupPluginRootCommand() but that one has external consumers, so I didn't want to break them in this PR 😅
The flag-set that was returned is a pointer to the command's Flags(), which is in itself passed by reference (as it is modified / set up). This patch removes the flags return, to prevent assuming it's different than the command's flags. While SetupRootCommand is exported, a search showed that it's only used internally, so changing the signature should not be a problem. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_redundant_flag
branch
from
e625566 to
88f44ec
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4389 +/- ##
=======================================
Coverage 59.37% 59.37%
=======================================
Files 288 288
Lines 24748 24746 -2
=======================================
- Hits 14694 14693 -1
+ Misses 9170 9169 -1
Partials 884 884 |
neersighted
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flag-set that was returned is a pointer to the command's Flags(), which
is in itself passed by reference (as it is modified / set up).
This patch removes the flags return, to prevent assuming it's different than
the command's flags.
While SetupRootCommand is exported, a search showed that it's only used internally,
so changing the signature should not be a problem.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)