cli/command/container: don't mutate ConfigFile.DetachKeys#4337
Merged
thaJeztah merged 4 commits intodocker:masterfrom Jun 12, 2023
Merged
cli/command/container: don't mutate ConfigFile.DetachKeys#4337thaJeztah merged 4 commits intodocker:masterfrom
thaJeztah merged 4 commits intodocker:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This function returned the whole response, but we already handled the warnings included in the response as part of the function. All consumers of this function only used the container-ID, so let's simplify and return just that (it's a non-exported func, so we can change the signature again if we really need it). Signed-off-by: Sebastiaan van Stijn <[email protected]>
This code was introduced in moby/moby@15aa2a6, but from those changes, it appears that overwriting the config value was merely out of convenience, and that struct being used as an intermediate. While changing the config here should be mostly ephemeral, and not written back to the config-file, let's be clear on intent, and not mutatte the config as part of this code. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Member
Author
|
@laurazard ptal 🤗 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cli/command/container: attach: rename var that collided with import
cli/command/container: TestCreateContainerImagePullPolicy: use sub-tests
cli/command/container: createContainer(): return container-ID
This function returned the whole response, but we already handled the
warnings included in the response as part of the function. All consumers
of this function only used the container-ID, so let's simplify and return
just that (it's a non-exported func, so we can change the signature again
if we really need it).
cli/command/container: don't mutate ConfigFile.DetachKeys
This code was introduced in moby/moby@15aa2a6 (moby/moby#15666),
but from those changes, it appears that overwriting the config value was
merely out of convenience, and that struct being used as an intermediate.
While changing the config here should be mostly ephemeral, and not written
back to the config-file, let's be clear on intent, and not mutatte the config
as part of this code.