docs: fix the max-concurrent-downloads and max-concurrent-uploads configs documentation#3834
Merged
sam-thibault merged 1 commit intodocker:masterfrom Dec 2, 2022
Conversation
luismulinari
force-pushed
the
fix_max_concurrent_downloads_uploads_docs
branch
from
e12cc26 to
4ffe527
Compare
Collaborator
|
Thanks! Lines 319 to 323 in b655203 cli/contrib/completion/zsh/_docker Lines 2768 to 2769 in 1d6c6e2 |
Contributor
Author
|
Thanks for reviewing this, @vvoland. Sure! I'll do it. |
…ocumentation This fix tries to address issues raised in moby/moby#44346. The max-concurrent-downloads and max-concurrent-uploads limits are applied for the whole engine and not for each pull/push command. Signed-off-by: Luis Henrique Mulinari <[email protected]>
luismulinari
force-pushed
the
fix_max_concurrent_downloads_uploads_docs
branch
from
4ffe527 to
684dcd7
Compare
Contributor
Author
|
Done @vvoland. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3834 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 288 288
Lines 24605 24605
=======================================
Hits 14571 14571
Misses 9159 9159
Partials 875 875 |
vvoland
approved these changes
Oct 31, 2022
sam-thibault
approved these changes
Oct 31, 2022
luismulinari
changed the title
Contributor
Author
|
Hey @sam-thibault! Thanks for the review! Is this good to be merged? Can I help with anything else? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes moby/moby#44346.
- What I did
The
max-concurrent-downloadsandmax-concurrent-uploadslimits are applied for the whole engine and not for each pull/push command, as informed on the commands docs.This PR fixes the
max-concurrent-downloadsandmax-concurrent-uploadscommand documentation.- How I did it
Fixed the docs. All the investigation part is documented on moby/moby#44346
- How to verify it
See moby/moby#44346
- Description for the changelog
Fix the max-concurrent-downloads and max-concurrent-uploads configs documentation. The
max-concurrent-downloadsandmax-concurrent-uploadslimits are applied for the whole engine and not for each pull/push command.