build: replace uses of archive.CanonicalTarNameForPath#3762
Merged
thaJeztah merged 1 commit intodocker:masterfrom Sep 1, 2022
Merged
build: replace uses of archive.CanonicalTarNameForPath#3762thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
As it's just an alias for filepath.IsAbs. Also added a normalize step in TrimBuildFilesFromExcludes, so that callers are not _required_ to first normalize the path. We are considering deprecating and/or removing this function in the archive package, so removing it in the cli code helps transitioning if we decide to deprecate and/or remove it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
area/builder
kind/refactor
vvoland
approved these changes
Sep 1, 2022
tonistiigi
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it's just an alias for filepath.IsAbs. Also added a normalize step in
TrimBuildFilesFromExcludes, so that callers are not required to first
normalize the path.
We are considering deprecating and/or removing this function in the archive
package, so removing it in the cli code helps transitioning if we decide to
deprecate and/or remove it.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)