Sleep for 1.5 seconds before looking at the resize error#3584
Merged
thaJeztah merged 1 commit intodocker:masterfrom May 3, 2022
Merged
Sleep for 1.5 seconds before looking at the resize error#3584thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
This test is very flaky, the retry loop runs for 550ms and some more, 750ms is cleary not enough for everything to set and for the cli to return the tty resize error. A sleep of 1.5 seconds in this test should be enough for the retry loop to finish. Signed-off-by: Djordje Lukic <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #3584 +/- ##
=======================================
Coverage 59.46% 59.47%
=======================================
Files 285 287 +2
Lines 24171 24174 +3
=======================================
+ Hits 14373 14377 +4
Misses 8931 8931
+ Partials 867 866 -1 |
thaJeztah
approved these changes
May 2, 2022
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
let me know when it's ready to be merged (you mentioned wanting to run CI a couple of times)
Member
Author
|
OK I've ran the CI 5-6 times yesterday and 4 times today, I think this can be merged. |
Member
|
whoop; let's get it in 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Sleep for 1.5 seconds before looking at the resize error
This test is very flaky, the retry loop runs for 550ms and some more, 750ms is cleary not enough for everything to set and for the cli to return the tty resize error. A sleep of 1.5 seconds in this test should be enough for the retry loop to finish.
Relates to #3554
- How I did it
- How to verify it
Run the CI a lot of times
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
