Fix incorrect pointer inputs to json.Unmarshal#3434
Conversation
See https://github.com/howardjohn/go-unmarshal-double-pointer for more info on why this is not safe and how this is detected. Signed-off-by: John Howard <[email protected]>
|
Oh, nice find!! I see you have that checker; do you know if there's any (existing) linter that would detect these? We currently use Are you planning to contribute your checker as a linter and/or as addition to an existing linter? |
thaJeztah
added
kind/bugfix
|
@thaJeztah I have been in touch with some more knowledgeable Golang folks at my company and they have a plan to implement a linter but I don't think its a top priority. I tried myself but ran into trouble since it can be tricky when a method gets an |
|
oh! I see I never replied to you |
2 participants
See https://github.com/howardjohn/go-unmarshal-double-pointer for more
info on why this is not safe and how this is detected.