vendor: compose-on-kubernetes v0.5.0 to remove use of github.com/golang/glog#3411
Merged
thaJeztah merged 1 commit intodocker:masterfrom Feb 14, 2022
Merged
vendor: compose-on-kubernetes v0.5.0 to remove use of github.com/golang/glog#3411thaJeztah merged 1 commit intodocker:masterfrom
thaJeztah merged 1 commit intodocker:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3411 +/- ##
=======================================
Coverage 57.33% 57.33%
=======================================
Files 304 304
Lines 26379 26379
=======================================
Hits 15124 15124
Misses 10329 10329
Partials 926 926 |
thaJeztah
force-pushed
the
no_glog
branch
2 times, most recently
from
d0b13aa to
357827f
Compare
Member
Author
|
Moved the vendor-script changes to #3412, and temporarily rebased this one on top |
…ng/glog glog has the same issue as k8s.io/klog, and is calling `user.Current()` inside an `init()`; see kubernetes/klog@466fbb6 Calling `user.Current()` on Windows can result in remove connections being made to get the user's information, which can be a heavy call. See docker#2420 glog was only used in a single location in compose-on-kubernetes, so we may as well remove it. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
changed the title
Member
Author
|
Let me bring this one in; thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glog has the same issue as k8s.io/klog, and is calling
user.Current()inside aninit(); see kubernetes/klog@466fbb6Calling
user.Current()on Windows can result in remove connections being made to get the user's information, which can be a heavy call. See #2420glog was only used in a single location in compose-on-kubernetes, so we may as well remove it.
compose-on-kubernetes has been archived, so (for now) vendoring from my fork (thaJeztah/compose-on-kubernetes#1), but we should consider to temporarily un-archive it, and get this fix in upstream.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)