Add an info field for features like buildkit#3083
Open
sudo-bmitch wants to merge 1 commit intodocker:masterfrom
Open
Add an info field for features like buildkit#3083sudo-bmitch wants to merge 1 commit intodocker:masterfrom
sudo-bmitch wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Brandon Mitchell <[email protected]>
AkihiroSuda
reviewed
May 5, 2021
| type clientInfo struct { | ||
| Debug bool | ||
| Context string | ||
| Features map[string]string |
Collaborator
There was a problem hiding this comment.
Can this be just []string?
Contributor
Author
There was a problem hiding this comment.
Yes, that's something I'm very open to. I think there are several options and I'm happy to go with any:
Features map[string]stringwith each feature able to take a value, this could be something other than enabled for other features.Features []stringand just have each feature a name. Simple and too the point.Features []featurewhere feature is justtype feature struct { name string }today, but able to add more fields if needed in the future. This mirrors the plugin layout.Buildkit booljust hardcode a single field for buildkit, and then need another for the next feature later. This has the advantage of being easy to template with--format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brandon Mitchell [email protected]
- What I did
Added a client feature section to
docker infoto expose whether buildkit is enabled. I'm not certain this should be a map of strings, if we want an array like Plugins, hardcode a struct, or some other way to track. This would fix moby/moby#42350- How I did it
This is using the same call from
docker build --helpto adjust the help message for arguments on whether buildkit is enabled.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)