docs: Fix wrong bridge driver option#2984
Merged
thaJeztah merged 1 commit intodocker:masterfrom May 31, 2021
Merged
Conversation
Signed-off-by: OKA Naoya <[email protected]>
thaJeztah
approved these changes
May 31, 2021
| | `com.docker.network.bridge.host_binding_ipv4` | `--ip` | Default IP when binding container ports | | ||
| | `com.docker.network.driver.mtu` | `--mtu` | Set the containers network MTU | | ||
| | `com.docker.network.container_interface_prefix` | - | Set a custom prefix for container interfaces | | ||
| | `com.docker.network.container_iface_prefix` | - | Set a custom prefix for container interfaces | |
Member
There was a problem hiding this comment.
Hmmm.. good catch; looks indeed the correct name; https://github.com/moby/moby/blob/a8a769f04f7ae44117772943ef0f4607b54e05ff/vendor/github.com/docker/libnetwork/netlabel/labels.go#L54-L55
// ContainerIfacePrefix can be used to override the interface prefix used inside the container
ContainerIfacePrefix = Prefix + ".container_iface_prefix"Looks like moby/moby#31811 updated the changelog incorrectly, probably because the title of the libnetwork pull request had the wrong name in it (I just fixed that); moby/libnetwork#1667
Member
|
opened moby/moby#42446 and docker/docs#12921 to fix the changelog entry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed a wrong bridge driver option for
docker network create.- How I did it
Fixed documentation.
- How to verify it
With the option in current documentation, the name of the interface in a container remains unchanged (eth0).
With
com.docker.network.container_iface_prefix, it works perfectly.- Description for the changelog
N/A
- A picture of a cute animal (not mandatory but encouraged)
This is Pui Pui Molcar, a stop-motion anime featuring Molmots, booming in Japan. (@molcar_anime)