Skip to content

Fix stack output stream#298

Merged
vdemeester merged 2 commits into
docker:masterfrom
dnephin:fix-stack-out-stream
Jul 10, 2017
Merged

Fix stack output stream#298
vdemeester merged 2 commits into
docker:masterfrom
dnephin:fix-stack-out-stream

Conversation

@dnephin

@dnephin dnephin commented Jul 5, 2017

Copy link
Copy Markdown
Contributor

Fixes moby/moby#33954

"Nothing found in stack" should go to stderr

Also cleaned up some duplication in task format selection

@codecov-io

codecov-io commented Jul 5, 2017

Copy link
Copy Markdown

Codecov Report

Merging #298 into master will decrease coverage by <.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
- Coverage   48.93%   48.92%   -0.01%     
==========================================
  Files         177      177              
  Lines       11846    11840       -6     
==========================================
- Hits         5797     5793       -4     
  Misses       5687     5687              
+ Partials      362      360       -2

@thaJeztah thaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

Copy link
Copy Markdown
Member

ping @vdemeester PTAL

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@vdemeester
vdemeester merged commit af6c089 into docker:master Jul 10, 2017
@GordonTheTurtle GordonTheTurtle added this to the 17.07.0 milestone Jul 10, 2017
nobiit pushed a commit to nobidev/docker-cli that referenced this pull request Nov 19, 2025
[17.11] vendor: update to github.com/vbatts/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants