fix --update-order and --rollback-order flags#2927
Merged
Conversation
thaJeztah
requested changes
Jan 12, 2021
thaJeztah
left a comment
thaJeztah
left a comment
Member
There was a problem hiding this comment.
Thanks! Change itself looks good, but perhaps you can add a test (see my comment)
Signed-off-by: Jim Lin <[email protected]>
jimlinntu
force-pushed
the
fix_update_rollback_order
branch
from
January 18, 2021 14:42
2a27929 to
26a6a72
Compare
| o.update = updateOptions{order: "start-first"} | ||
| o.rollback = updateOptions{order: "start-first"} | ||
|
|
||
| service, err := o.ToService(context.Background(), &fakeClient{}, flags) |
Contributor
There was a problem hiding this comment.
nit picking:
assert.NilError(t, err)
expected := "start-first"
assert.Equal(t, service.UpdateConfig.Order, expected)
assert.Equal(t, service.RollbackConfig.Order, expected)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes moby/moby#41581
- What I did
Add missing flags in
anyChangedfunction in two places, resolving moby/moby#41581- How I did it
Just add the missing flags.
- How to verify it
docker service create --update-order start-first --restart-condition none --no-healthcheck --name start-first-test alpine tail -f /dev/nulldocker inspect start-first-test(Before this commit)
(After this commit):
- Description for the changelog
fix
--update-orderand--rollback-orderflags when only--update-orderor--rollback-orderis provided.- A picture of a cute animal (not mandatory but encouraged)
🦁