Fix panic when failing to get DefaultAuthConfig#2918
Merged
Conversation
Member
Author
|
For reference; the problem situation is here; cli/cli/command/registry/login.go Lines 118 to 123 in 88c6089 If |
Member
Author
Member
Author
|
Discussing with @tiborvass @cpuguy83 - I'll update this to do a nil check outside of the function |
thaJeztah
force-pushed
the
fix_login_panic
branch
from
January 7, 2021 21:10
dfa6632 to
a04c926
Compare
Commit f32731f fixed a potential panic when an error was returned while trying to get existing credentials. However, other code paths currently use the result of `GetDefaultAuthConfig()` even in an error condition; this resulted in a panic, because a `nil` was returned. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
fix_login_panic
branch
from
January 7, 2021 21:11
a04c926 to
c2820a7
Compare
Member
Author
|
@tiborvass @cpuguy83 updated; PTAL |
Codecov Report
@@ Coverage Diff @@
## master #2918 +/- ##
==========================================
- Coverage 57.05% 57.04% -0.02%
==========================================
Files 297 297
Lines 18653 18655 +2
==========================================
- Hits 10643 10641 -2
- Misses 7151 7154 +3
- Partials 859 860 +1 |
Member
Author
|
@silvin-lubecki PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2890 Non-root user "docker login" results in panic SIGSEGV segmentation violation
fixes moby/moby#41771 Command 'docker login' does not work
fixes #2954
Commit f32731f (#2818) fixed a potential panic when an error was returned while trying to get existing credentials.
However, other code paths currently use the result of
GetDefaultAuthConfig()even in an error condition; this resulted in a panic, because anilwas returned.We should fix the other code paths to be more resilient, and to not use the result of
GetDefaultAuthConfig()if an error occurs, but starting with a minimal patch to fix the immediate issue.- Description for the changelog