Add ulimits support to docker service and docker stack deploy#2660
Closed
akerouanton wants to merge 3 commits intodocker:masterfrom
Closed
Add ulimits support to docker service and docker stack deploy#2660akerouanton wants to merge 3 commits intodocker:masterfrom
akerouanton wants to merge 3 commits intodocker:masterfrom
Conversation
ccf5e75 to
b9c148c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2660 +/- ##
==========================================
- Coverage 58.14% 58.12% -0.02%
==========================================
Files 295 295
Lines 21198 21238 +40
==========================================
+ Hits 12325 12345 +20
- Misses 7966 7982 +16
- Partials 907 911 +4 |
Member
Author
|
@thaJeztah This PR is ready for review 😉 |
…cd07 Includes the API changes regarding ulimits support on service endpoints. Signed-off-by: Albin Kerouanton <[email protected]>
This is related to moby/moby#40639. Signed-off-by: Albin Kerouanton <[email protected]>
This is related to moby/moby#40639. Signed-off-by: Albin Kerouanton <[email protected]>
Member
|
Thanks! |
silvin-lubecki
requested changes
Aug 10, 2020
Contributor
silvin-lubecki
left a comment
There was a problem hiding this comment.
Thank you @akerouanton for this PR 👍 The code looks good, but I think this PR lacks some tests. Do you think you could add some to the formater part and to the service update 🙏 ?
Collaborator
|
Just a couple of comments: Need to make sure the final list of ulimits removes duplicates and is sorted. |
Member
|
carried in #2712, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
--ulimittodocker service create;--ulimit-addand--ulimit-rmoptions todocker service update;Ulimitstodocker service inspect --pretty;docker stack deploy;This is related to moby/moby#40639.
- How I did it
- How to verify it
Given the following
docker-compose.yaml:docker service createdocker service updatedocker service inspectdocker stack deploy- Description for the changelog
Add
ulimitssupport todocker service create|update|inspectanddocker stack deploy- A picture of a cute animal (not mandatory but encouraged)